Avoid Error cloning error in Worker promise/rejection case #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
padolsey
commented
Jan 15, 2017
padolsey
commented
- See "An object could not be cloned" when promise is rejected with an error #44
- Specifically pass message/stack and then catch on the other side
- See #44 - Specifically pass message/stack and then catch on the other side
cdhowie
reviewed
Jan 15, 2017
| postMessage({ | ||
| cmd: 'deferred_reject_error', | ||
| token: data.token, | ||
| error: { |
There was a problem hiding this comment.
If we replace this (error) object literal with JSON.parse(JSON.stringify(r)) then we can side-step any structured cloning errors while still having a fairly complete view of the error.
There was a problem hiding this comment.
Ah yes, though shall probably have to resort to this as JSON.stringify(new Error('foo')) seems to give us nothing.
There was a problem hiding this comment.
Ah, right. There might even be an npm module for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.