Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle trailing whitespace in tag values #393

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Jul 1, 2024

Fixes #392.

RELEASE NOTES BEGIN

Value of a Tag no longer includes trailing whitespace (if any).

RELEASE NOTES END

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d850c2101eb3480697001c9466f85015

✔️ pre-commit SUCCESS in 2m 10s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 14s
✔️ specfile-tests-pip-deps SUCCESS in 1m 06s

specfile/tags.py Show resolved Hide resolved
nforro added 2 commits July 2, 2024 15:16
In theory this shouldn't be necessary, but it's better to be safe.

Signed-off-by: Nikola Forró <[email protected]>
@nforro nforro force-pushed the tags_trailing_ws branch from 19aab94 to cac33a0 Compare July 2, 2024 13:16
@nforro nforro added the mergeit Zuul, merge it! label Jul 2, 2024
@nforro
Copy link
Member Author

nforro commented Jul 2, 2024

regate

2 similar comments
@nforro
Copy link
Member Author

nforro commented Jul 2, 2024

regate

@nforro
Copy link
Member Author

nforro commented Jul 2, 2024

regate

@nforro
Copy link
Member Author

nforro commented Jul 2, 2024

Looks like Zuul is dead for good 😅

@nforro
Copy link
Member Author

nforro commented Jul 3, 2024

regate

@nforro nforro added mergeit Zuul, merge it! and removed mergeit Zuul, merge it! labels Jul 3, 2024
@majamassarini
Copy link
Member

recheck

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/13476268cd6a48649a098b093e689bf1

✔️ pre-commit SUCCESS in 2m 12s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 25s
✔️ specfile-tests-pip-deps SUCCESS in 1m 40s

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0d3614f1dbab4135b4fab57ca09cbf68

✔️ pre-commit SUCCESS in 2m 09s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9ace410 into main Jul 3, 2024
28 checks passed
@nforro nforro deleted the tags_trailing_ws branch July 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull_from_upstream fails if there is trailing whitespace at the end of the Source URL in the spec
2 participants