Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openscanhub prototype docs #909

Merged

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Jul 24, 2024

Related to #899
Related to packit/packit-service#2472

Copy link
Contributor

@lbarcziova lbarcziova self-assigned this Jul 24, 2024
@lbarcziova lbarcziova force-pushed the openscanhub-prototype branch from 8b65730 to fd35762 Compare July 29, 2024 11:35
Copy link
Contributor

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Jul 29, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1caaeef4f4544c23a99b7774aaf90a5c

✔️ pre-commit SUCCESS in 1m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e7467bc into packit:main Jul 29, 2024
4 checks passed
Comment on lines +770 to +774
:::info
This functionality is an initial prototype and both configuration and functionality
will likely change in the future.
We will be happy for any feedback regarding it, [please contact us](/#contact)!
:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lbarcziova lbarcziova deleted the openscanhub-prototype branch July 29, 2024 11:47
(*bool*) When set to `true` (the default), test job statuses are updated together with their corresponding
build job statuses. When set to `false`, while test jobs are waiting for their corresponding build jobs
to finish, their statuses remain in pending state and only build job statuses are updated, for example with
`SRPM build is in progress...` or `Starting RPM build...`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we write down when an user needs to put this key to false. I think it is not straightforward guessing it. I see you just moved this doc...
Still I will add something like the following...

Suggested change
`SRPM build is in progress...` or `Starting RPM build...`.
`SRPM build is in progress...` or `Starting RPM build...`.
You may want to disable the statuses update when you are experiencing problems with the number of Github API calls in your organization. This will lower the calls made by the Packit app.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too late 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majamassarini We can extend the description later if we see that it really has an effect and how big the effect is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majamassarini yes that's a good point, for context it would be nice to mention it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants