-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openscanhub prototype docs #909
Openscanhub prototype docs #909
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 1m 16s |
8b65730
to
fd35762
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 25s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 13s |
e7467bc
into
packit:main
:::info | ||
This functionality is an initial prototype and both configuration and functionality | ||
will likely change in the future. | ||
We will be happy for any feedback regarding it, [please contact us](/#contact)! | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(*bool*) When set to `true` (the default), test job statuses are updated together with their corresponding | ||
build job statuses. When set to `false`, while test jobs are waiting for their corresponding build jobs | ||
to finish, their statuses remain in pending state and only build job statuses are updated, for example with | ||
`SRPM build is in progress...` or `Starting RPM build...`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we write down when an user needs to put this key to false
. I think it is not straightforward guessing it. I see you just moved this doc...
Still I will add something like the following...
`SRPM build is in progress...` or `Starting RPM build...`. | |
`SRPM build is in progress...` or `Starting RPM build...`. | |
You may want to disable the statuses update when you are experiencing problems with the number of Github API calls in your organization. This will lower the calls made by the Packit app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too late 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majamassarini We can extend the description later if we see that it really has an effect and how big the effect is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majamassarini yes that's a good point, for context it would be nice to mention it
Related to #899
Related to packit/packit-service#2472