Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to reference a test repo in test job metadata #1021

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Allow to reference a test repo in test job metadata #1021

merged 1 commit into from
Mar 22, 2021

Conversation

mmuzila
Copy link
Contributor

@mmuzila mmuzila commented Mar 15, 2021

This change allows to specify distinct repository for tests.

Fixes: #968

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

jpopelka
jpopelka reviewed Mar 15, 2021
View reviewed changes
Copy link
Member

@jpopelka jpopelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

Would be nice to finish packit/packit#1155 so that tests here can pass.

packit_service/worker/testing_farm.py Show resolved Hide resolved
@mmuzila
Copy link
Contributor Author

mmuzila commented Mar 15, 2021

LGTM with one question.

Would be nice to finish packit/packit#1155 so that tests here can pass.

I want to merge it after release of packit/packit#1155. I probably should use WIP prefix for this PR.

@mmuzila mmuzila force-pushed the reference_test_repo branch from cd87fc4 to 29929b0 Compare March 18, 2021 14:59
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

TomasTomecek
TomasTomecek approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd wait for Jirka's approval as well

@TomasTomecek
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@mrc0mmand mrc0mmand mentioned this pull request Mar 19, 2021
Closed
@mmuzila mmuzila added the mergeit When set, zuul wil gate and merge the PR. label Mar 19, 2021
@TomasTomecek
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jpopelka jpopelka mentioned this pull request Mar 19, 2021
Merged
@jpopelka
Copy link
Member

recheck

@jpopelka
Copy link
Member

  • [packit-service-tests] : FAILURE in 2m 23s

It's still failing because we are now (since #977) using pre-built tests image instead of building it each time.
The pros are speed (over 2min instead of over 8min), the cons are that if you need to rebuild it because something has changed in packit since last push to this repo, you have to do it yourself in Actions, which is what I did just now.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@TomasTomecek TomasTomecek added mergeit When set, zuul wil gate and merge the PR. and removed mergeit When set, zuul wil gate and merge the PR. labels Mar 22, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

@mmuzila
Allow to reference a test repo in test job metadata
a5471e1 
This change allows to specify distinct repository for tests.
@mmuzila mmuzila force-pushed the reference_test_repo branch from 29929b0 to a5471e1 Compare March 22, 2021 13:21
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@TomasTomecek TomasTomecek added mergeit When set, zuul wil gate and merge the PR. and removed mergeit When set, zuul wil gate and merge the PR. labels Mar 22, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 17e0701 into packit:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference test repository in the test job metadata
3 participants
@mmuzila @TomasTomecek @jpopelka