Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy without --no-strict-optional #1433

Closed
jpopelka opened this issue Apr 4, 2022 · 5 comments
Closed

Run mypy without --no-strict-optional #1433

jpopelka opened this issue Apr 4, 2022 · 5 comments
Assignees
Labels
🌞 friday 🤟 Weekend is coming! good-first-issue Good for newcomers.

Comments

@jpopelka
Copy link
Member

jpopelka commented Apr 4, 2022

  1. remove --no-strict-optional from pre-commit-config
  2. run pre-commit run --all-files
  3. fix all errors

https://mypy.readthedocs.io/en/stable/kinds_of_types.html#no-strict-optional

See also packit/ogr#696 & packit/packit#1548

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jun 12, 2022
@jpopelka jpopelka removed the stale Is the issue still valid? label Jun 13, 2022
@FrNecas
Copy link

FrNecas commented Jun 30, 2022

I will try to fix this since I almost got burnt today by the presence of this option :)

@FrNecas FrNecas self-assigned this Jun 30, 2022
@TomasTomecek
Copy link
Member

TomasTomecek commented Jul 1, 2022

--no-strict-optional that's probably the most confusing option name I ever saw in my life


I finally get it! It's typing.Optional, not as "optional" in the actual sense 🤦‍♂

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Sep 21, 2022
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Dec 6, 2022
@TomasTomecek
Copy link
Member

Based on @FrNecas's recent comments, this would be an immense effort & not worth the time. Closing then.

@TomasTomecek TomasTomecek closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Repository owner moved this from backlog to done in Packit Kanban Board Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 friday 🤟 Weekend is coming! good-first-issue Good for newcomers.
Projects
Archived in project
Development

No branches or pull requests

3 participants