Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy without --no-strict-optional #696

Open
jpopelka opened this issue Apr 4, 2022 · 4 comments · May be fixed by #723
Open

Run mypy without --no-strict-optional #696

jpopelka opened this issue Apr 4, 2022 · 4 comments · May be fixed by #723
Labels
🌞 friday 🤟 Weekend is coming! good-first-issue Good for newcomers. stale Is the issue still valid?

Comments

@jpopelka
Copy link
Member

jpopelka commented Apr 4, 2022

  1. remove --no-strict-optional from pre-commit-config
  2. run pre-commit run --all-files
  3. fix all errors

https://mypy.readthedocs.io/en/stable/kinds_of_types.html#no-strict-optional

See also packit/packit#1548 & packit/packit-service#1433

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jun 12, 2022
@jpopelka jpopelka removed the stale Is the issue still valid? label Jun 13, 2022
@jpopelka
Copy link
Member Author

See also #251

@FrNecas FrNecas linked a pull request Jul 14, 2022 that will close this issue
1 task
@lachmanfrantisek lachmanfrantisek moved this to 📋 Backlog 🔟 in Packit Kanban Board Sep 6, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Nov 12, 2022
@jpopelka jpopelka mentioned this issue Sep 26, 2023
@majamassarini
Copy link
Member

Still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 friday 🤟 Weekend is coming! good-first-issue Good for newcomers. stale Is the issue still valid?
Projects
Status: backlog
Development

Successfully merging a pull request may close this issue.

2 participants