Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VM image build configuration for fedora 36 #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .packit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,27 @@ jobs:
- fedora-latest # branched version, rawhide updates are created automatically
- fedora-stable
- epel-9

# vm image build
- job: copr_build
trigger: pull_request
targets:
- fedora-36-x86_64
- fedora-37-x86_64
project: vm-image-ogr-demo
identifier: vm-image-demo

- job: vm_image_build
trigger: pull_request
copr_chroot: fedora-36-x86_64
owner: packit
project: vm-image-ogr-demo
image_customizations:
packages: [python3-ogr]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually need this, if the image is generated from the Copr build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean specify the package? I think yes but @TomasTomecek knows this better than me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the package. Agreed with you :D Though I'd expect this to be automatically installed because of the Copr build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need this right now.

I guess we could default to all binary RPMs produced by the latest build though we don't have a mechanism right now for that. Hence it's explicit like this.

image_distribution: fedora-36
image_request:
architecture: x86_64
image_type: aws
upload_request:
type: aws
options: {}