Skip to content

Commit

Permalink
Show error messages for Koji builds and Bodhi updates
Browse files Browse the repository at this point in the history
  • Loading branch information
lbarcziova committed Nov 27, 2024
1 parent 62f08d9 commit 8a448ae
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 0 deletions.
2 changes: 2 additions & 0 deletions frontend/src/apiDefinitions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ export interface KojiBuild {
task_id: string;
web_url: string;
build_submission_stdout: string | null;
error_message: string | null;
}

// /api/koji-tag-requests
Expand Down Expand Up @@ -307,6 +308,7 @@ export interface BodhiUpdate {
submitted_time: number;
update_creation_time: number | null;
web_url: string | null;
error_message: string | null;
}

// /api/testing-farm/results
Expand Down
14 changes: 14 additions & 0 deletions frontend/src/components/bodhi/BodhiUpdate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import {
Card,
CardBody,
CodeBlock,
CodeBlockCode,
Content,
DescriptionList,
DescriptionListDescription,
Expand Down Expand Up @@ -97,6 +99,18 @@ export const BodhiUpdate = () => {
{" "}
{data.koji_nvrs}
</DescriptionListDescription>
{data.error_message ? (
<>
<DescriptionListTerm>Error message</DescriptionListTerm>
<DescriptionListDescription>
<CodeBlock>
<CodeBlockCode>{data.error_message}</CodeBlockCode>
</CodeBlock>
</DescriptionListDescription>
</>
) : (
<></>
)}
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Expand Down
14 changes: 14 additions & 0 deletions frontend/src/components/koji/KojiBuild.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import {
Card,
CardBody,
CodeBlock,
CodeBlockCode,
Content,
DescriptionList,
DescriptionListDescription,
Expand Down Expand Up @@ -158,6 +160,18 @@ export const KojiBuild = () => {
<span>not provided</span>
)}
</DescriptionListDescription>
{data.error_message ? (
<>
<DescriptionListTerm>Error message</DescriptionListTerm>
<DescriptionListDescription>
<CodeBlock>
<CodeBlockCode>{data.error_message}</CodeBlockCode>
</CodeBlock>
</DescriptionListDescription>
</>
) : (
<></>
)}
</DescriptionListGroup>
<DescriptionListGroup>
<DescriptionListTerm>
Expand Down

0 comments on commit 8a448ae

Please sign in to comment.