Fixed NULL pointer exception on connecting nodes (https://github.com/… #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assigning new pointer for _proxyWidget (issue paceholder#441), only do so if the pointer is NULL. Otherwise we repeatedly create new and leave the existing hanging if the method is called multiple times.
|
Added null check (in my fork) around the line in question to avoid multiple allocations - see comment on #441. |
nolankramer
approved these changes
Sep 27, 2024
nolankramer
approved these changes
Oct 10, 2024
|
Fixed in master by checking for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/issues/441)
Moved the creation of the ProxyWidget in NodeGraphicsObject::embedQWidget() (line 84 ff.) out of the if { } block to ensure that it wouldn't be NULL when someone tried to dereference it. See issue #441. May be relevant also for #417 and #442.