Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rails 6 compatibility #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ktemby
Copy link

@ktemby ktemby commented Apr 25, 2023

Situation:
Presently introjs-rails will only work up to Rails 5, and cannot be installed on Rails 6 due to a pessimistic dependency on thor ~>0.14.

Background:
The official introjs documentation still points to this gem, but the gem hasn't been updated in almost 8 years (since May 18 2015).

Assessment:
The current gem shows the following error due to the block.

Could not find compatible versions
Because every version of introjs-rails depends on thor ~> 0.14
  and railties >= 6.1.7 depends on thor ~> 1.0,
  every version of introjs-rails is incompatible with railties >= 6.1.7.
And because rails >= 6.1.7, < 7.0.4.3 depends on railties = 6.1.7,
  every version of introjs-rails is incompatible with rails >= 6.1.7, < 7.0.4.3.
So, because Gemfile depends on rails ~> 6.1.7
  and Gemfile depends on introjs-rails >= 0,
  version solving has failed.

Smoke testing shows relaxing this dependency constraint and updating the source file works (only personal project tested), and presumably works for the author of these two CR's (@ahaikal).

Recommendation:
Merge the two CR's into the official repo, and (ideally) generate a new release of nodejs-rails (as 1.0.1).

Alternatives Considered:

  1. Forking a copy of ahaikal's fix and not contributing back to the primary repo. Not recommended since this fix is valuable to others.
  2. Pointing the introjs documentation for rails at ahaikal's repo, and forcing folks to use github references in their gemfiles. Not recommended since this seems unnecessary and awkward.
  3. Removing introjs-rails from my project because it's not maintained. Not ideal since there's a workable solution here.

P.S., this is my first pull request on an OSS project, and it's a request for pulling someone else's CR's. Feedback welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants