Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation:
Presently introjs-rails will only work up to Rails 5, and cannot be installed on Rails 6 due to a pessimistic dependency on
thor ~>0.14
.Background:
The official introjs documentation still points to this gem, but the gem hasn't been updated in almost 8 years (since May 18 2015).
Assessment:
The current gem shows the following error due to the block.
Smoke testing shows relaxing this dependency constraint and updating the source file works (only personal project tested), and presumably works for the author of these two CR's (@ahaikal).
Recommendation:
Merge the two CR's into the official repo, and (ideally) generate a new release of nodejs-rails (as 1.0.1).
Alternatives Considered:
P.S., this is my first pull request on an OSS project, and it's a request for pulling someone else's CR's. Feedback welcome.