DPDK: Use generic CPU instructions and skip AVX512 #20
Conversation
This commits removes AVX512 support and enables generic CPU options for the DPDK build. The IPDK CI builds on Azure VMs which support AVX512. However, since Virtualbox doesn't support this (see [1] and [2]), we can skip this for p4-dpdk-target when building DPDK as a part of the p4-dpdk-target repo. Fixes: ipdk-io/ipdk#118 [1] https://forums.virtualbox.org/viewtopic.php?t=86047 [2] https://forums.virtualbox.org/viewtopic.php?f=7&t=87131 Signed-off-by: Kyle Mestery <[email protected]>
|
@jamescchoi See the breadcrumbs above, would be curious on your thoughts of this PR. |
|
@mestery Can you include @vsureshkumarp for review for this DPDK repo build change? He would be more knowledgeable on this. |
|
Thanks for the pointer @jamescchoi! @vsureshkumarp can you review this one please? |
| @@ -1,8 +1,13 @@ | |||
| all: | |||
| $(shell ./apply_patch.sh > /dev/null 2>&1) | |||
| stat dpdk_src/build > /dev/null 2>&1 || \ | |||
| (cd dpdk_src && meson -Dprefix=$(prefix) build && \ | |||
| cd build && ninja -j48 && ninja install) | |||
| (cd dpdk_src && meson -Dcpu_instruction_set=generic -Dprefix=$(prefix) build && \ | |||
There was a problem hiding this comment.
These changes apply for all the builds including real hardware. I feel it is better to introduce another build option and utilize it specially for VirtualBox builds instead of making it generic.
There was a problem hiding this comment.
Can you provide some guidance on how we might do that? I would appreciate any help to either take over this PR or guide me here. We'll need to expose this up to the IPDK level as well (e.g. P4-OVS) so it's configurable from that build level.
This commits removes AVX512 support and enables generic CPU options for
the DPDK build. The IPDK CI builds on Azure VMs which support AVX512.
However, since Virtualbox doesn't support this (see [1] and [2]), we
can skip this for p4-dpdk-target when building DPDK as a part of the
p4-dpdk-target repo.
Fixes: ipdk-io/ipdk#118
[1] https://forums.virtualbox.org/viewtopic.php?t=86047
[2] https://forums.virtualbox.org/viewtopic.php?f=7&t=87131
Signed-off-by: Kyle Mestery [email protected]