Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Basic externs for PNA: Meter, Counter, Hash, etc #1261

Closed

Conversation

rupesh-chiluka-marvell
Copy link
Contributor

Part of Issue: #1245

@qobilidop
Copy link
Member

Is there a way we can test the code?

@antoninbas
Copy link
Member

Is there a way we can test the code?

I think the priority should be to add some PNA-specific tests (see #1255 (comment)).

@rupesh-chiluka-marvell
Copy link
Contributor Author

Is there a way we can test the code?

I think the priority should be to add some PNA-specific tests (see #1255 (comment)).

Yes. Ok.

Copy link
Member

@qobilidop qobilidop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests! Now it looks good from my side.

@@ -327,6 +327,7 @@ AC_CONFIG_FILES([Makefile
targets/psa_switch/Makefile
targets/psa_switch/tests/Makefile
targets/pna_nic/Makefile
targets/pna_nic/tests/Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: format to align indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned it.
tabs are used for indentation in configuration files. Everywhere else, spaces are used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does feel there could be some common code factored out to test both psa_switch and pna_nic's hash and internet_checksum blocks. But that could probably be left as future work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I was thinking about how to do it. Based on future tests, we can factor out common code.

@antoninbas
Copy link
Member

@rupesh-chiluka-marvell please break up this PR. Everything related to the pna-demo-L2-one-table.json test should be in its own PR, which I'd like to review & merge first. Unless I am missing something, this basic end-to-end test of PNA has no dependencies on the externs you want to add as par of this PR.

@rupesh-chiluka-marvell
Copy link
Contributor Author

@rupesh-chiluka-marvell please break up this PR. Everything related to the pna-demo-L2-one-table.json test should be in its own PR, which I'd like to review & merge first. Unless I am missing something, this basic end-to-end test of PNA has no dependencies on the externs you want to add as par of this PR.

Yes. Ok.

@rupesh-chiluka-marvell
Copy link
Contributor Author

rupesh-chiluka-marvell commented Aug 2, 2024

@rupesh-chiluka-marvell please break up this PR. Everything related to the pna-demo-L2-one-table.json test should be in its own PR, which I'd like to review & merge first. Unless I am missing something, this basic end-to-end test of PNA has no dependencies on the externs you want to add as par of this PR.

Hi @antoninbas, @qobilidop , I created a new PR for the basic test of PNA here: #1262. Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants