-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Basic externs for PNA: Meter, Counter, Hash, etc #1261
Added Basic externs for PNA: Meter, Counter, Hash, etc #1261
Conversation
Is there a way we can test the code? |
I think the priority should be to add some PNA-specific tests (see #1255 (comment)). |
Yes. Ok. |
ac0ebd6
to
6e0f6cd
Compare
6e0f6cd
to
0cefe83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests! Now it looks good from my side.
@@ -327,6 +327,7 @@ AC_CONFIG_FILES([Makefile | |||
targets/psa_switch/Makefile | |||
targets/psa_switch/tests/Makefile | |||
targets/pna_nic/Makefile | |||
targets/pna_nic/tests/Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: format to align indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned it.
tabs are used for indentation in configuration files. Everywhere else, spaces are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does feel there could be some common code factored out to test both psa_switch
and pna_nic
's hash
and internet_checksum
blocks. But that could probably be left as future work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was thinking about how to do it. Based on future tests, we can factor out common code.
@rupesh-chiluka-marvell please break up this PR. Everything related to the |
Yes. Ok. |
Hi @antoninbas, @qobilidop , I created a new PR for the basic test of PNA here: #1262. Please review it. |
Part of Issue: #1245