Challenge: don't show completed users as participants. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display page for a challenge shows help providers, participants, and people who have completed the challenge. The participant list included people who had completed the challenge. We want to list only those who haven't completed the challenge as participants. A simple "exclude" filter applied in project_tags to create a list "participants_not_completed". I inserted this in what I think are the appropriate locations in projects/_user_list.html. I tested this using the http://127.0.0.1:8000/en/groups/test-webmaking-101-7/ challenge that was created using the Django "loaddata" command, on the data in projects/fixtures. See http://i.imgur.com/W1DSv.png .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address issue #127 .
Display page for a challenge shows help providers, participants, and people who have completed the challenge. The participant list included people who have completed the challenge.
We want to list only those who haven't completed the challenge in the participants list.
A simple "exclude" filter applied in project_tags to create a list "participants_not_completed". I inserted this in what I think are the appropriate locations in projects/_user_list.html.
I tested this using the
http://127.0.0.1:8000/en/groups/test-webmaking-101-7/
challenge that was created using the Django "loaddata" command, on the data in projects/fixtures.
See http://i.imgur.com/W1DSv.png .