Updates for Multiboard correlator tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gpetruc
commented
Jul 4, 2023
•
gpetruc
commented
- upstream updates of cms-l1t-offline up to l1t-phase2-v75 (updated pattern file producers with CSP support)
- support for compression of pattern files: DemonstratorTools: support transparent compression of pattern files [12_5_X] cms-l1t-offline/cmssw#1147
- implement fillDescriptions for seeded-cone jet producer and fix input tag mismatch in the dump file producer https://gitlab.cern.ch/cms-cactus/phase2/firmware/correlator-common/-/issues/21 (this was already fixed in cms-sw/master by the l1t contacts during integration of an older PR) @thesps
- use firmware-matching emulator configuration for hgcal forward region (differences are not really visible in the standard configuration as the multiplicities are small, but they showed up when relaxing the BDT cuts in tests for Draft: Integration branch for HGCal multiboard test [DO NOT MERGE] #119 )
- cleanup and improve configuration of pattern files
Produce l1t::EGamma, l1tp2::CaloCrystalClusters, and 1tp2::CaloTower output collections in same style as TDR (previous) emulator. Address code formatting comments. Refactor firmware-style code to abstracted functions and classes.
Fix build-bot comments on constructor/initializers
Remove cmsRun config files which are not unit tests from the PR.
Add hls to BuildFile since plugins and interface depend on ap_int.h
Fixes errors that were thrown by scram build -k -j 16 check-headers
Add digitized collections and squash all changes not in cms-sw#41224.
Squash commits not in cms-sw#41224 addressing: - use two's-complements in DigitizedClusterGT - fix LSB value in DigitizedClusterGT
Address comments to rename Phase2L1CaloEGammaEmulator.h to phase2L1CaloEGammaUtils.h, move includes to after ifndef guards, and rename ifndef guards
…outputToSAAtLowpT Add flag to drop quality of low-pt TkMuons without an SA match
…v1.16 Updated correlator layer 1 e/gamma sorter
…-emp-format-1252patch1 Demonstrator tools: Support for EMP v0.7.x buffer file format
fix format issue
Conflicts: L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h L1Trigger/L1CaloTrigger/interface/Phase2L1RCT.h
…rrelEmulator Devel phase2eg standalone barrel emulator
Update Correlator layer 1 barrel "TDR" regionizer emulator
Let it be controlled by the configuation parameter, as it should, instead of always on.
P2GMT: Disable hard-coding of debug printout
…sion_l1t DemonstratorTools: support transparent compression of pattern files [12_5_X]
…Propagate new workflow to central L1T and GTT configurations, fix l1t broken tags l1t naming for GTTFileWriter Remove track vertex association from track selection module. Separated off track-vertex association into separate plugin. Partial update to GTT Emulation workflow, switch geometry to D88 which is the Phase2 Baseline in 12_5. add Alexx's updates to TTTrack_TrackWord.h, update to CMSSW_13 l1t tracks tag, update l1tVertexProducer default Update GTTFileReader to l1t naming. Update L1TrackJetEmulatorProducer.cc to accept TVA tracks from l1tTrackVertexAssociationProducer, unify some typedefs with other GTT modules, update l1tTrackJetsEmulation_cfi.py accordingly. Create separate copies of TS and TVA for the vertex finding, jet finding, and Missing Et. Update names to match VertexFinder configs commonly used. Add l1tVertexFinderSim and l1tVertexFinderEmu with fastHisto and fastHistoEmulation algorithms, and proper default input tags for easy process.load calls Update createFirmwareInputFiles_cfg.py for new TS, TVA, VF, JF workflow with new defaults. VertexFinderEmu to VertexFinderEmulator to sync with common usage Switch back to L1 in typedef's, update l1tTrackJets_cif.py PV input tag. l1t naming for L1Trigger/L1TTrackMatch/plugins/L1FastTrackingJetProducer.cc and L1Trigger/L1TTrackMatch/python/l1tFastTrackingJetProducer_cfi.py fixup l1t naming for GTTFileWriter TS and TVA split update, split part 1 of commit b17fb0e Multiple fixes for data flow of consumes and produces for the non-emulator GTT modules. Try to disable JF internal track selection for firmware inputs. fixup TrackJet types. fixup more fixup l1tTrackJetsEmulation_cfi.py Simplify configurations for track selection and vertex association through usage of clone. Remove debugging code from createFirmwareInputFiles_cfg.py First attempt at update to SimL1Emulator_cff.py based on new TS+VF+TVA workflow and default configurations for GTT. Fix runTheMatrix.py errors, SimL1Emulator_cff.py Update to new default on track selection and vertex association for jets, disabling external modules and keeping internal selection active
Update VertexFinder to 256 bins, delay truncation of track pt until histogramming is finished to match HDLS firmware. Update typedefs, switch vertex-finder to use selected tracks instead of converted, sync to global/EDProducer from cmssw master FastHisto update, split part 2 of commit b17fb0e Adjust VertexFinder inversion table.
…pdated JetFinding workflow to more L1T workflows Update L1TkObjectProducers_cff.py and L1TrackMET_cfg.py for TrackSelection insertion before VertexFinding Add TrackSelection in front of VertexFinding and remove redundant configuration in make_l1ctLayer1_dumpFiles_cfg.py make_l1ct_patternFiles_cfg.py l1emulator_cff.py Make input tags non-optional, ifConsumes permits non-existent tags (default) if bool is set to false
Add updated L1TrackObjectNtupleMaker code and config, removed redundant l1vertices input tags. Apply code-format updates to L1TrackObjectNtupleMaker.cc
…update-vXIII Phase 2 fastHistoEmulation updated to 256 bins, with associated Track Selection changes
…rsion LUT, with comments to clarify choice.
…tension Phase 2 match GTTFileWriter cfi and source parameter name
…e LUTBins constant, ad the LUTShift.
…ction for the MET cos LUT, match the strict dependence on kCosLUTBins constant as in firmware.
…T with truncation of phi value, as in firmware.
…rsionLUT Phase 2 GTT inversion LUT harmonization
Phase 2 GTT MET cos LUT update (backport)
gpetruc
changed the title
gpetruc
force-pushed
the
multiboard_correlator
branch
from
2754962 to
547611b
Compare
|
Now rebased on l1t-phase2-v75 |
gpetruc
force-pushed
the
multiboard_correlator
branch
from
547611b to
dfbebc1
Compare
|
Merging here to clear the field for new developments, any feedback from code review in CMSSW master will come as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.