Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external dependencies #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

uilianries
Copy link

Using only third party folder keeps this project stuck over the same version always.

This PR includes the CMake option to be able to use external dependencies (magic_enum and visit_struct).

Some extra changes:

  • Moved the third party folder location, to reflect its role, an external project.
  • Updated the local copy of magic_enum to the latest version (0.3.5)
  • Add STRUCTOPT_EXTERNAL_DEPS to use magic_enum and visit_struct from the system
  • Removed Conanfile recipe, because is now part of official Conan Center: https://conan.io/center/recipes/structopt

@perseoGI
Copy link

Hi @p-ranav, did you have the chance to dig into this PR?

@Ahajha
Copy link
Contributor

Ahajha commented Oct 27, 2024

@uilianries A PR to update the vendored dependencies was just merged, you can probably simplify this PR

@uilianries
Copy link
Author

@Ahajha Thank you for pinging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants