Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a dedicated currency object instead of float #255

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Using a dedicated currency object instead of float #255

merged 4 commits into from
Dec 19, 2023

Conversation

oxisto
Copy link
Owner

@oxisto oxisto commented Dec 18, 2023

Otherwise we have weird rounding errors. Fixes #254

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e1dfcb8) 86.02% compared to head (228ff13) 86.16%.

Files Patch % Lines
gen/portfolio.go 90.32% 3 Missing ⚠️
gen/portfolio_sql.go 80.00% 3 Missing ⚠️
service/portfolio/portfolio.go 60.00% 1 Missing and 1 partial ⚠️
service/securities/securities.go 50.00% 1 Missing and 1 partial ⚠️
gen/securities_sql.go 94.11% 1 Missing ⚠️
service/securities/quote_provider_ing.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   86.02%   86.16%   +0.13%     
==========================================
  Files          20       20              
  Lines         959     1019      +60     
==========================================
+ Hits          825      878      +53     
- Misses         92       97       +5     
- Partials       42       44       +2     
Flag Coverage Δ
unittests 86.16% <91.48%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxisto oxisto merged commit 24829d5 into main Dec 19, 2023
4 checks passed
@oxisto oxisto deleted the currency branch December 19, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use integer for currencies instead of float
1 participant