Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of bank account #253

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Initial implementation of bank account #253

merged 3 commits into from
Dec 29, 2023

Conversation

oxisto
Copy link
Owner

@oxisto oxisto commented Dec 17, 2023

This PR includes an initial implementation of a bank account, which holds cash. It also adds more transaction types (not all of them are functional yet) and includes a very basic calculation of the current cash to a portfolio snapshot.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (0e223b4) 86.23% compared to head (af8f0d9) 86.61%.
Report is 1 commits behind head on main.

❗ Current head af8f0d9 differs from pull request most recent head a1b5255. Consider uploading reports for the commit a1b5255 to get more accurate results

Files Patch % Lines
gen/account_sql.go 90.69% 3 Missing and 1 partial ⚠️
service/portfolio/transactions.go 71.42% 2 Missing and 2 partials ⚠️
service/portfolio/snapshot.go 50.00% 2 Missing and 1 partial ⚠️
finance/calculation.go 85.71% 2 Missing ⚠️
gen/portfolio.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   86.23%   86.61%   +0.38%     
==========================================
  Files          20       23       +3     
  Lines        1024     1143     +119     
==========================================
+ Hits          883      990     +107     
- Misses         97      104       +7     
- Partials       44       49       +5     
Flag Coverage Δ
unittests 86.61% <90.06%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxisto oxisto force-pushed the bank-account branch 3 times, most recently from ebf2be7 to 2e0e0f5 Compare December 20, 2023 08:43
@oxisto oxisto linked an issue Dec 20, 2023 that may be closed by this pull request
@oxisto oxisto force-pushed the bank-account branch 3 times, most recently from a8ebd0d to c5874e1 Compare December 29, 2023 17:28
@oxisto oxisto marked this pull request as ready for review December 29, 2023 17:30
@oxisto oxisto enabled auto-merge (squash) December 29, 2023 18:41
@oxisto oxisto merged commit 6a03f2e into main Dec 29, 2023
2 checks passed
@oxisto oxisto deleted the bank-account branch December 29, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include cash in portfolio snapshot calculation
1 participant