Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented simple quote provider for ING #166

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

oxisto
Copy link
Owner

@oxisto oxisto commented Oct 7, 2023

Can be useful for derivates.

Fixes #165

Can be useful for derivates.

Fixes #165
@oxisto oxisto force-pushed the ing-provider-latest-quote branch from 3c4a463 to a459d1b Compare October 7, 2023 19:16
@oxisto oxisto enabled auto-merge (squash) October 7, 2023 19:16
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #166 (a459d1b) into main (01afb56) will decrease coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   86.22%   86.07%   -0.16%     
==========================================
  Files          19       20       +1     
  Lines         900      919      +19     
==========================================
+ Hits          776      791      +15     
- Misses         87       89       +2     
- Partials       37       39       +2     
Flag Coverage Δ
unittests 86.07% <80.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
service/securities/quote_provider.go 100.00% <100.00%> (ø)
import/csv/csv_importer.go 96.00% <50.00%> (-1.94%) ⬇️
service/securities/quote_provider_ing.go 86.66% <86.66%> (ø)

@oxisto oxisto merged commit 21fe0b4 into main Oct 7, 2023
2 checks passed
@oxisto oxisto deleted the ing-provider-latest-quote branch October 7, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a quote provider for derivates
1 participant