Implemented StableApiDefinition::[bignum_positive_p|bignum_negative_p]. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianks
reviewed
Dec 4, 2024
| @@ -96,6 +96,16 @@ impl StableApiDefinition for Definition { | |||
| is_immediate || !test | |||
| } | |||
|
|
|||
| #[inline] | |||
| unsafe fn bignum_positive_p(&self, obj: VALUE) -> bool { | |||
| crate::rb_big_sign(obj) == 1 | |||
There was a problem hiding this comment.
let's re-implement the flag checks to avoid dylib dispatch (and so rustc can inline more). This will keep the performance on par with the C macros
There was a problem hiding this comment.
Forget about the truffle failures for now, we'll circle back on those and add a new definition file
There was a problem hiding this comment.
You mean like this? aa85110 I had to whitelist ruby_fl_types in order to bindgen to generate. let me know if this is what you meant 😅
There was a problem hiding this comment.
yes exactly... suprised to see they were gone..... 🤔
ianks
reviewed
Dec 4, 2024
goyox86
force-pushed
the
goyox86/stable-api-bignum-methods
branch
from
6aa0a98 to
22fd020
Compare
goyox86
commented
Dec 5, 2024
| bindings | ||
| .blocklist_item("^ruby_fl_type.*") | ||
| .blocklist_item("^_bindgen_ty_9.*") | ||
| bindings.blocklist_item("^_bindgen_ty_9.*") |
There was a problem hiding this comment.
Not sure how else would I have gotten ruby_fl_type in the bindings 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #451
For the Rust implementation I choose a similar approach than CRuby.