Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent modunload once underlay has been set #485

Merged
merged 5 commits into from
May 21, 2024
Merged

Commits on Apr 5, 2024

  1. Prevent modunload once underlay has been set

    This PR moves the underlay teardown logic from xde_detach into a new
    ioctl (and opteadm command) to unset the XDE underlay. Detach will now
    fail so long as the underlay is set -- this successfully prevents
    `modunload` from knocking us down after this state has been set.
    
    The semantics are more or less what you'd expect:
    * Clearing the underlay will fail if there exists a port.
    * Clearing the underlay will fail if there is no underlay.
    * Driver detach now requires that you `opteadm clear-xde-underlay`.
    FelixMcFelix committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bca9fd0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    851946c View commit details
    Browse the repository at this point in the history
  2. Review feedback.

    Following discussion, we need to figure out a safer quiesce on rx as
    there is a theoretical bad ordering between `xde_rx` and underlay
    removal.
    FelixMcFelix committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f2dc5db View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Explain safety of MCH dropping behaviour

    After some research into MAC promiscuous callback behaviour, I've
    verified that we don't need to do our own quiescing since the cleanup
    operations will await any active promisc list walkers terminating. I've
    explained this logic for the benefit of others and/or future Kyle.
    FelixMcFelix committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a651039 View commit details
    Browse the repository at this point in the history
  2. Clear XDE underlay as part of raw xtask install

    Minor papercut I just ran into, this should keep the command
    zero-friction.
    FelixMcFelix committed May 13, 2024
    Configuration menu
    Copy the full SHA
    53d091a View commit details
    Browse the repository at this point in the history