update to Dropshot 0.13.0 (minimum changes) #7050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
changed the title
davepacheco
commented
Nov 13, 2024
| @@ -89,6 +89,7 @@ impl<'a> RequestBuilder<'a> { | |||
| body: dropshot::Body::empty(), | |||
| expected_status: None, | |||
| allowed_headers: Some(vec
…dap/drafts/dropshot-update
ahl
approved these changes
Nov 13, 2024
| @@ -89,6 +89,7 @@ impl<'a> RequestBuilder<'a> { | |||
| body: dropshot::Body::empty(), | |||
| expected_status: None, | |||
| allowed_headers: Some(vec![ | |||
| http::header::CONNECTION, | |||
| @@ -7,7 +7,7 @@ | |||
| "url": "https://oxide.computer", | |||
| "email": "[email protected]" | |||
| }, | |||
| "version": "20241204.0" | |||
| "version": "20241204.0.0" | |||
There was a problem hiding this comment.
I hadn't considered this consequence. I can't see any problems with it; this version string does appear in CLI/SDK stuff...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the minimum changes to update Dropshot to the newly-released 0.13.0. For more on this, see: https://github.com/oxidecomputer/dropshot/blob/main/CHANGELOG.adoc#breaking-changes
After this one, I will go back to #6730 to update Omicron to use the new builder interface that's in the latest release.
(I initially created this PR as a test-build of Omicron against Dropshot 0.13.0. See oxidecomputer/dropshot#1115.)