realize: rewrite suspicious append with assignment #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The append in form of `a = append(b, ...)` is suspicious
due to mistatching `a` and `b`.
In this particular case, there is a subtle syntax-level
difference due to embedding, but same field is being assigned,
so more "safe" looking code is something like:
r.Projects = append(r.Projects, Project{exit: make(chan os.Signal, 1)})
But even better, this can be re-written as assignment, without append.
erikdubbelboer
suggested changes
Jan 21, 2019
| @@ -11,7 +11,7 @@ import ( | |||
|
|
|||
| func TestRealize_Stop(t *testing.T) { | |||
| r := Realize{} | |||
| r.Projects = append(r.Schema.Projects, Project{exit: make(chan os.Signal, 1)}) | |||
| r.Projects = []Project{exit: make(chan os.Signal, 1)} | |||
There was a problem hiding this comment.
This is actually a syntax error now. You're building an slice but only have one pair of brackets. It should be:
r.Projects = []Project{{exit: make(chan os.Signal, 1)}}There was a problem hiding this comment.
My mistake, thanks.
Used github UI to edit the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The append in form of
a = append(b, ...)is suspiciousdue to mistatching
aandb.In this particular case, there is a subtle syntax-level
difference due to embedding, but same field is being assigned,
so more "safe" looking code is something like:
But even better, this can be re-written as assignment, without append.