Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default hlog.Logger back to a mutex #121

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Switch default hlog.Logger back to a mutex #121

merged 1 commit into from
Sep 13, 2023

Conversation

bconway
Copy link
Member

@bconway bconway commented Sep 13, 2023

  • atomic.Value requires consistent types, which doesn't work well for interfaces.
  • Remove pkg/metric use of init().
  • Sync vendor/ for updated dependencies.
  • All test variations pass.

@bconway
Switch default hlog.Logger back to a mutex
79549e2 
- atomic.Value requires consistent types, which doesn't work well for interfaces.
- Remove pkg/metric use of `init()`.
- Sync `vendor/` for updated dependencies.
- All test variations pass.
@bconway bconway merged commit 1dc327a into main Sep 13, 2023
@bconway bconway deleted the bconway_hlog_update_mutex branch September 13, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bconway