-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐝 Add the ability to prefix algolia index names #3337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsyencken
force-pushed
the
prefixed-algolia-index
branch
from
March 13, 2024 11:23
7d4d4bb
to
ae259a6
Compare
danyx23
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only looked at the query part - thanks for cleaning that up as you pass it by :)
This is in order to support multiple staging servers having their own index inside one Algolia staging application.
larsyencken
force-pushed
the
prefixed-algolia-index
branch
2 times, most recently
from
March 15, 2024 11:59
21225d0
to
c158491
Compare
marcelgerber
approved these changes
Mar 18, 2024
larsyencken
force-pushed
the
prefixed-algolia-index
branch
from
March 18, 2024 11:30
24eb1ec
to
67b0a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes to make it easier to experiment with changes to Algolia.
ALGOLIA_INDEX_PREFIX
settingThe
ALGOLIA_INDEX_PREFIX
setting prepends a prefix to all index names.E.g.
ALGOLIA_INDEX_PREFIX=dev-lars
will causedev-lars-pages
,dev-lars-charts
anddev-lars-explorers
to be usedmake reindex
Refreshes Algolia search indexes, creating them if they're missing, including updating any index settings that have changed.
Requires
ALGOLIA_ID
andALGOLIA_SECRET_KEY
, plusALGOLIA_INDEXING=true
.See: https://github.com/owid/ops/issues/158