🔨 add test case to see if in queries work with param arrays

owid · Mar 16, 2024 · aa50f14 · aa50f14
1 parent 37780f9
commit aa50f14
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/db/tests/basic.test.ts b/db/tests/basic.test.ts
@@ -158,14 +158,22 @@ test("knex interface", async () => {
         expect(usersFromRawQuery.length).toBe(2)
 
         // Check if in queries work as expected
-        const usersFromRawQueryWithInClause: Pick<DbPlainUser, "email">[] =
+        const usersFromRawQueryWithInClauseAsObj: Pick<DbPlainUser, "email">[] =
             await knexRaw(trx, "select * from users where email in (:emails)", {
                 emails: [
                     usersFromRawQuery[0].email,
                     usersFromRawQuery[1].email,
                 ],
             })
-        expect(usersFromRawQueryWithInClause.length).toBe(2)
+        expect(usersFromRawQueryWithInClauseAsObj.length).toBe(2)
+
+        const usersFromRawQueryWithInClauseAsArray: Pick<
+            DbPlainUser,
+            "email"
+        >[] = await knexRaw(trx, "select * from users where email in ?", [
+            [usersFromRawQuery[0].email, usersFromRawQuery[1].email],
+        ])
+        expect(usersFromRawQueryWithInClauseAsArray.length).toBe(2)
 
         await deleteUser(trx, 2)
     }, knexInstance)