🐛 fix double escaping of featured images

owid · Feb 7, 2024 · 83c8974 · 83c8974
1 parent d426639
commit 83c8974
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/site/LongFormPage.tsx b/site/LongFormPage.tsx
@@ -116,9 +116,8 @@ export const LongFormPage = (props: {
                 pageDesc={pageDesc}
                 canonicalUrl={canonicalUrl}
                 imageUrl={
-                    post.imageUrl
-                        ? encodeURI(formatUrls(post.imageUrl))
-                        : undefined
+                    // uriEncoding is taken care of inside the Head component
+                    post.imageUrl ? formatUrls(post.imageUrl) : undefined
                 }
                 baseUrl={baseUrl}
             >

diff --git a/site/gdocs/OwidGdocPage.tsx b/site/gdocs/OwidGdocPage.tsx
@@ -73,10 +73,9 @@ export default function OwidGdocPage({
                 pageDesc={pageDesc}
                 canonicalUrl={canonicalUrl}
                 imageUrl={
+                    // uriEncoding is taken care of inside the Head component
                     featuredImageFilename
-                        ? encodeURI(
-                              filenameToUrl(featuredImageFilename, baseUrl)
-                          )
+                        ? filenameToUrl(featuredImageFilename, baseUrl)
                         : undefined
                 }
                 baseUrl={baseUrl}