Merge pull request #4270 from owid/fix-default-thumbnails-in-search

🐛 fix default gdoc thumbnails not rendering in gdocs
owid · Dec 9, 2024 · 6fb21e8 · 6fb21e8
2 parents 1e169ad + 4c9b3b4
commit 6fb21e8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/baker/algolia/utils/pages.ts b/baker/algolia/utils/pages.ts
@@ -162,7 +162,7 @@ function getGdocThumbnailUrl(gdoc: OwidGdocPostInterface): string {
     if (gdoc.content["featured-image"]) {
         return getThumbnailPath(gdoc.content["featured-image"])
     }
-    return `/${DEFAULT_GDOC_FEATURED_IMAGE}`
+    return `/images/published/${DEFAULT_GDOC_FEATURED_IMAGE}`
 }
 
 function generateGdocRecords(

diff --git a/site/search/SearchPanel.tsx b/site/search/SearchPanel.tsx
@@ -11,6 +11,7 @@ import {
     groupBy,
     uniqBy,
     Region,
+    DEFAULT_GDOC_FEATURED_IMAGE,
 } from "@ourworldindata/utils"
 import {
     InstantSearch,
@@ -65,6 +66,12 @@ import { ChartHit } from "./ChartHit.js"
 const siteAnalytics = new SiteAnalytics()
 
 function PagesHit({ hit }: { hit: IPageHit }) {
+    // a temporary fix for articles that have been indexed without the directory
+    const src =
+        hit.thumbnailUrl === `/${DEFAULT_GDOC_FEATURED_IMAGE}`
+            ? `/images/published/${DEFAULT_GDOC_FEATURED_IMAGE}`
+            : hit.thumbnailUrl
+
     return (
         <a
             href={`${BAKED_BASE_URL}/${hit.slug}`}
@@ -76,7 +83,7 @@ function PagesHit({ hit }: { hit: IPageHit }) {
             {hit.thumbnailUrl && (
                 <div className="search-results__page-hit-img-container">
                     <img
-                        src={hit.thumbnailUrl}
+                        src={src}
                         role="presentation"
                         className="search-results__page-hit-img"
                     />