Bind worklfow with variables anytime #3203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelAudren
changed the title
Mykhailenko
approved these changes
May 28, 2018
| @@ -389,6 +389,9 @@ public JobType getType() { | |||
| } | |||
| } | |||
|
|
|||
| //replace variables | |||
| commonPropertiesHolder.getVariables().putAll(replaceVariablesInJobVariablesMap(commonPropertiesHolder.getVariables(),replacementVariables)); | |||
There was a problem hiding this comment.
It is a bit hard to read. In the same line you 'putAll', and also replace something.
I do not know what you can change.. but maybe you know.
Thanks
| @@ -468,12 +471,11 @@ private void handleCancelJobOnErrorAttribute(CommonAttribute commonPropertiesHol | |||
| * Leave the method with the cursor at the end of 'ELEMENT_VARIABLES' tag | |||
| * | |||
| * @param cursorVariables the streamReader with the cursor on the 'ELEMENT_VARIABLES' tag. | |||
| * @param replacementVariables variables which have precedence over the one defined in the job | |||
| //* @param replacementVariables variables which have precedence over the one defined in the job | |||
There was a problem hiding this comment.
Why do you need two slashes?
|
I'm closing this PR (duplicate of #3205) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue #3198