Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement translation support for config options #579

Merged
merged 14 commits into from
Apr 18, 2024
Merged

Implement translation support for config options #579

merged 14 commits into from
Apr 18, 2024

Conversation

xen-42
Copy link
Member

@xen-42 xen-42 commented Apr 18, 2024

Resolves #578

Uses the NH style, where it looks for a translations folder with json files named after the TextTranslation.Language enums and then reads from UIDictionary.

@MegaPiggy MegaPiggy changed the base branch from master to dev April 18, 2024 19:17
@xen-42 xen-42 marked this pull request as draft April 18, 2024 19:39
@xen-42 xen-42 marked this pull request as ready for review April 18, 2024 19:55
Copy link
Member

@MegaPiggy MegaPiggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xen-42 xen-42 merged commit a85aa7e into dev Apr 18, 2024
3 checks passed
@xen-42 xen-42 deleted the translations branch April 18, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translation support for config options
4 participants