upgrade to @bufbuild v2 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS-ovm
requested changes
Dec 13, 2024
There was a problem hiding this comment.
- Remove the "generated code" commit, it breaks the build. The actual generated code is handled in sdp-go and sdp-js, not here.
- Manually verify the built sdp-go code from a local checkout.
- update the README. As it currently stands I get this error when trying to
npx buf generate:
vscode ➜ /workspace/sdp (@bufbuild-v2) $ npx buf generate
npm error could not determine executable to run
npm error A complete log of this run can be found in: /home/vscode/.npm/_logs/2024-12-13T14_46_56_613Z-debug-0.log
vscode ➜ /workspace/sdp (@bufbuild-v2) $
This reverts commit 39d443e.
DavidS-ovm
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.