Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate timing fields #294

Merged
merged 1 commit into from
Dec 8, 2024
+8 −7
Merged

Deprecate timing fields #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions items.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,17 @@ message Metadata {
// The time that the item was found
google.protobuf.Timestamp timestamp = 4;

// How long the source took to execute in total when processing the
// Query
google.protobuf.Duration sourceDuration = 5;
// How long the source took to execute in total when processing the Query.
//
// (deprecated) This is no longer sent as streaming responses make this metric
// impossible to calculate on a per-item basis
google.protobuf.Duration sourceDuration = 5 [deprecated = true];

// How long the source took to execute per item when processing the
// Query
google.protobuf.Duration sourceDurationPerItem = 6;
//
// (deprecated) This is no longer sent
google.protobuf.Duration sourceDurationPerItem = 6 [deprecated = true];

// Whether the item should be hidden/ignored by user-facing things such as
// GUIs and databases.
Expand All @@ -134,9 +138,6 @@ message Metadata {
// information, but we don't actually want to show the user all the commands
// that were run, just the final item returned by the source
bool hidden = 7;

// The UUID of the QUERY that caused this item to be found
bytes sourceQueryUUID = 8 [deprecated = true];
}

// This is a list of items, like a List() would return
Expand Down
Loading