Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) initial pagination for ListHomeChanges #233

Merged
merged 1 commit into from
Jul 18, 2024
Merged

(feat) initial pagination for ListHomeChanges #233

merged 1 commit into from
Jul 18, 2024

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Jul 5, 2024 •
edited
Loading

resolves #230

DavidS-ovm
DavidS-ovm reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@DavidS-ovm DavidS-ovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes to capture more of the design considerations we had coming into this.

changes.proto Outdated Show resolved Hide resolved
changes.proto Show resolved Hide resolved
getinnocuous
getinnocuous approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@getinnocuous getinnocuous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this works for me, i've not looked at the implementation details but in terms of a response this looks great.

@tphoney tphoney force-pushed the initial_pagination branch from 2b84e8a to a88e87b Compare July 17, 2024 14:06
@tphoney tphoney force-pushed the initial_pagination branch from a88e87b to 356583c Compare July 17, 2024 14:58
@tphoney tphoney marked this pull request as ready for review July 18, 2024 10:19
@tphoney tphoney merged commit df05c30 into main Jul 18, 2024
1 check passed
@tphoney tphoney deleted the initial_pagination branch July 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS-ovm DavidS-ovm DavidS-ovm left review comments

@getinnocuous getinnocuous getinnocuous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create pagination
3 participants
@tphoney @getinnocuous @DavidS-ovm