Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved blast radius to presets #232

Merged
merged 6 commits into from
Jul 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,33 @@ message BlastRadiusConfig {
int32 linkDepth = 2;
}

// This account config is stored in the `kv.Store` protobuf key-value store in
// the api-server database. This means that as long as we don't have any
// *breaking* changes to the protobuf, we shouldn't need to do a migration. If
// however we do need to change this message in a breaking way, we will need to
// do some kind of a migration (depending on the change)
message AccountConfig {
// The blast radius config for this account
BlastRadiusConfig blastRadius = 1;
enum BlastRadiusPreset {
// Customise advanced limits.
CUSTOM = 0;
// Runs a shallow scan for dependencies. Reduces time takes to calculate
// blast radius, but might mean some dependencies are missed
QUICK = 1;
// An optimised balance between time taken and discovery.
DETAILED = 2;
// Discovers all possible dependencies, might take a long time and
// discover items that are less likely to be relevant to a change.
FULL = 3;
}

// The preset that we should use when calculating the blast radius for a
// change. If this is set to "CUSTOM" then the `blastRadius` config should be
// set
BlastRadiusPreset blastRadiusPreset = 2;

// The blast radius config for this account, this is only required if the
// preset is "CUSTOM"
optional BlastRadiusConfig blastRadius = 1;
}

message GetAccountConfigRequest {}
Expand Down
Loading