Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API Endpoints for account config #224

Closed
wants to merge 3 commits into from

Conversation

dylanratcliffe
Copy link
Member

@dylanratcliffe dylanratcliffe commented Jun 15, 2024

This is where we will store config for the blast radius. This is the first step for https://github.com/overmindtech/api-server/issues/953

This is where we will store config for the blast radius
This allows someone to customise the behaviour to for example calculate a lightweight blast radius for less important changes
Copy link
Contributor

@DavidS-ovm DavidS-ovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be stored in ConfigService, which is already holding CLI configuration values. My thinking is that configuration schema is gonna be more prone to change and hardcoding it in sdp is not gonna suit us well.

@dylanratcliffe
Copy link
Member Author

Decisions

  • At the SDP level, we basically we leave it as-is, but pull the values to the top level
  • At the database level, we use the existing logic as generic key value store, where the key identifies the schema of the thing we're saving, and the value is just the JSON of that thing. However since the current one is text, we should create a new table that stores all this stuff. This is a generic kv store where the values are always protobuf binary, like a protobuf document store.
    • For account-specific vs user-specific keys, we want to keep these in separate tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants