Added API endpoints that allow users to delete themselves from Auth0 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS-ovm
reviewed
Apr 30, 2024
| @@ -118,9 +128,18 @@ message AdminCreateTokenRequest { | |||
| service ManagementService { | |||
| // Get the details of the account that this user belongs to | |||
| rpc GetAccount(GetAccountRequest) returns (GetAccountResponse); | |||
| // Deletes the user's account | |||
|
|
|||
| // Deletes the user's account. If a user calls this and logs in again, they | |||
There was a problem hiding this comment.
Suggested change
| // Deletes the user's account. If a user calls this and logs in again, they | |
| // Deletes the user's account and all associated resources, including other users in this account. If a user calls this and logs in again, they |
| // everything Overmind has on them, they should use DeleteAccount to delete | ||
| // their Overmind account and all the data it contains, then call this to | ||
| // remove themselves from Auth0 | ||
| rpc DeleteOwnUser(DeleteOwnUserRequest) returns (DeleteOwnUserResponse); |
There was a problem hiding this comment.
how is this different from RevokeInvite(self)?
|
Maybe I'm overthinking this. Maybe DeleteAccount should just delete the account in overmind, all the users that have that account (in overmind) and propagate that deletion to Auth0? I can't think of a reason why you'd want to do anything else. @DavidS-ovm thoughts? |
|
Closing in favour of @DavidS-ovm's suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also related to https://github.com/overmindtech/frontend/issues/1198. It create API endpoints that will be implement on the api-server and allow users to delete their actual users, not just the Overmind account that backs them