Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitForHealthy and status reporting to KeepaliveSources #126

Merged
merged 2 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions account.proto
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
syntax = "proto3";

import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";
import "google/protobuf/timestamp.proto";

package account;

Expand Down Expand Up @@ -74,12 +74,12 @@ message CreateAccountResponse {

message AdminGetAccountRequest {
// The name of the account to get
string name = 1;
string name = 1;
}

message DeleteAccountRequest {
// The name of the account to delete
string name = 1;
string name = 1;
}
message DeleteAccountResponse {}

Expand Down Expand Up @@ -229,7 +229,7 @@ message CreateSourceResponse {
}

message GetSourceRequest {
bytes UUID = 1;
bytes UUID = 1;
}

message GetSourceResponse {
Expand All @@ -254,8 +254,17 @@ message DeleteSourceRequest {

message DeleteSourceResponse {}

message KeepaliveSourcesRequest {}
message KeepaliveSourcesResponse {}
message KeepaliveSourcesRequest {
// Set to true to have the API call wait until the source is up and healthy
bool waitForHealthy = 1;
}
message KeepaliveSourcesResponse {
// returns true if any of the sources did not come up in time
bool failed = 1;

// returns an indication of why not all sources were healthy
string error = 2;
}

message CreateTokenRequest {
// The Public NKey of the user that is requesting a token
Expand Down
1 change: 1 addition & 0 deletions bookmarks.proto
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import "items.proto";
option go_package = "github.com/overmindtech/sdp-go;sdp";

service BookmarksService {
// returns all bookmarks of the current user. note that this does not include the actual bookmark data, use GetBookmark for that
rpc ListBookmarks(ListBookmarksRequest) returns (ListBookmarkResponse);
rpc CreateBookmark(CreateBookmarkRequest) returns (CreateBookmarkResponse);
rpc GetBookmark(GetBookmarkRequest) returns (GetBookmarkResponse);
Expand Down
Loading