Skip to content

Commit

Permalink
Deprecate timing fields
Browse files Browse the repository at this point in the history
The fact that we are noe streaming responses makes these redundant. I've also removed the queryUUID as it has been deprecated for a long time and is no longer used
  • Loading branch information
dylanratcliffe committed Dec 8, 2024
1 parent 9357c3a commit e439a47
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions items.proto
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,17 @@ message Metadata {
// The time that the item was found
google.protobuf.Timestamp timestamp = 4;

// How long the source took to execute in total when processing the
// Query
google.protobuf.Duration sourceDuration = 5;
// How long the source took to execute in total when processing the Query.
//
// (deprecated) This is no longer sent as streaming responses make this metric
// impossible to calculate on a per-item basis
google.protobuf.Duration sourceDuration = 5 [deprecated = true];

// How long the source took to execute per item when processing the
// Query
google.protobuf.Duration sourceDurationPerItem = 6;
//
// (deprecated) This is no longer sent
google.protobuf.Duration sourceDurationPerItem = 6 [deprecated = true];

// Whether the item should be hidden/ignored by user-facing things such as
// GUIs and databases.
Expand All @@ -134,9 +138,6 @@ message Metadata {
// information, but we don't actually want to show the user all the commands
// that were run, just the final item returned by the source
bool hidden = 7;

// The UUID of the QUERY that caused this item to be found
bytes sourceQueryUUID = 8 [deprecated = true];
}

// This is a list of items, like a List() would return
Expand Down

0 comments on commit e439a47

Please sign in to comment.