Skip to content

Commit

Permalink
Move the additional risk calculation status fields into RiskCalculati…
Browse files Browse the repository at this point in the history
…onStatus

... to avoid duplication of the `message` field
  • Loading branch information
DavidS-ovm committed Feb 12, 2024
1 parent 56a289d commit ca7aad7
Showing 1 changed file with 8 additions and 13 deletions.
21 changes: 8 additions & 13 deletions changes.proto
Original file line number Diff line number Diff line change
Expand Up @@ -717,19 +717,6 @@ message GetChangeRisksResponse {
// The status of the risk calculation
RiskCalculationStatus riskCalculationStatus = 1;

// The description of the current step within the STATUS_INPROGRESS status.
// This will only be populated when the status is STATUS_INPROGRESS
string stepDescription = 2;

// The current step within the STATUS_INPROGRESS status. These give more
// granularity and should be shown to the user so they can see that the
// calculation is progressing
int32 currentStep = 3;

// The total num,ber of steps within the STATUS_INPROGRESS status
int32 totalSteps = 4;


// The risks that are related to this change
repeated Risk risks = 5;

Expand Down Expand Up @@ -973,6 +960,14 @@ message RiskCalculationStatus {
// status could show this message e.g. if a calculation was skipped because
// the user opted out or didn't have enough credits
string message = 2;

// The total number of steps within the STATUS_INPROGRESS status
int32 numSteps = 3;

// The current step within the STATUS_INPROGRESS status. These give more
// granularity and should be shown to the user so they can see that the
// calculation is progressing
int32 currentStep = 4;
}

////////////////
Expand Down

0 comments on commit ca7aad7

Please sign in to comment.