Skip to content

Commit

Permalink
Add a deadline to LoadBookmarks and Expand
Browse files Browse the repository at this point in the history
Since loading bookmarks executes queries, it also needs to have a deadline
  • Loading branch information
DavidS-ovm committed Sep 21, 2023
1 parent 02518d7 commit 007c08d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions gateway.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package gateway;
import "items.proto";
import "responses.proto";
import "google/protobuf/duration.proto";
import "google/protobuf/timestamp.proto";


// _____/\\\\\\\\\\\____/\\\\\\\\\\\\_____/\\\\\\\\\\\\\___
Expand Down Expand Up @@ -147,6 +148,8 @@ message LoadBookmark {
bytes msgID = 2;
// set to true to force fetching fresh data
bool ignoreCache = 3;
// The time at which the gateway should stop processing the queries spawned by this request
google.protobuf.Timestamp deadline = 4;
}

message BookmarkLoadResult {
Expand Down
2 changes: 2 additions & 0 deletions items.proto
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ message Expand {
// request. It should be stored as 128 bytes, as opposed to the textual
// representation
bytes UUID = 3;
// The time at which the gateway should stop processing the queries spawned by this request
google.protobuf.Timestamp deadline = 4;
}

// This message is sent to the gateway to instruct it to "undo" an Expand. This
Expand Down

0 comments on commit 007c08d

Please sign in to comment.