Added boolean for whether queries are running #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@getinnocuous This is the boolean that we discussed, you should be able to use this to determine if we should show the spinner or not |
|
How does this get consumed? Does it require a call each time to get the value? |
|
Given its a getter I'm not 100% sure how react will handle it. I'm hoping you can just bind |
|
Hopefully it's smart enough to see the underlying value change and then change detection can handle it. If it doesn't work we can always do another event handler |
|
Closing in favour of implementing it as an event listener in React |
auto-merge was automatically disabled
October 23, 2023 08:45
Pull request was closed
dylanratcliffe
deleted the
89-add-querystatus-messages-to-tracking-in-requestprogress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.