20 create generic Kube source #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
DavidS-ovm
reviewed
May 15, 2023
Co-authored-by: David Schmitt <[email protected]>
…nto 20-create-generic-kube-source
DavidS-ovm
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Kube
Fixes #19
Fixes #20
Fixes #21
Note: This is a monster and I don't expect you to review everything. The main thing here is the developer experience and whether or not I've missed anything
This refactors the old kubernetes source to use much more modern standards (like Go generics), this means each source is very simple to write and the vast majority of the code is shared, with each source basically only defining the links that should be inlcuded.
Explainer videos:
How the generics work
2023-05-15.16-16-50.mp4
Developer experience writing a source
2023-05-15.16-19-35.mp4
Testing
2023-05-15.16-21-26.mp4
Running
2023-05-15.16-26-00.mp4
Things left to do