Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle signals at the command level #86

Closed
wants to merge 1 commit into from
Closed

Handle signals at the command level #86

wants to merge 1 commit into from

Conversation

dylanratcliffe
Copy link
Member

This means we can use a context to propagate cancellation, which is what they are designed for. Seems like this is a more elegant solution

@DavidS-om Can I please get a preliminary review on this and I'll add to my current PR if approved?

@dylanratcliffe
Handle signals at teh command level
3f057ee 
This means we can use a context to propagate cancellation, which is what they are designed for. Seems like this is a more elegant solution
@dylanratcliffe dylanratcliffe linked an issue Oct 12, 2023 that may be closed by this pull request
Create teams CLI #84
Closed
DavidS-ovm
DavidS-ovm approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@DavidS-ovm DavidS-ovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I'd love viper to be able to have that code shared in the root cmd, but I think there's no good way to pass the ctx through to the sub commands.

@dylanratcliffe
Copy link
Member Author

Nice thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS-ovm DavidS-ovm DavidS-ovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create teams CLI
2 participants
@dylanratcliffe @DavidS-ovm