WIP (maint) disable spinners in debug mode

[tphoney]

this is just a POC ? what do you think

pterm has no concept of a non tty mode. from what i saw / read

[dylanratcliffe]

I think if we're going to disable spinners in a non-tty mode, we should be doing it in a wrapper rather than directly within the command. For example we would create a wrapper library that exposes a couple of spinner options that we know we use, which the commands then call. It would be that library's job to detect if we're running in a TTY and have a fallback printing method if we aren't. I don't like the idea of conflating presentation logic with business logic everywhere

[DavidS-ovm]

does setting pterm.DisableStyling() in PTermSetup() work, instead of this? (See pterm.RawOutput for details)

[tphoney]

@DavidS-ovm i had tried disabling styling had no affect, it continued to spam the terminal. 👎

agreed separation of the business and presentation logic would be good ™️

[tphoney]

long story short, this is annoying when running in vscode, i have a separate pr to force the cli tool into the terminal, rather than a debug console.