Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture failed mappings #616

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Capture failed mappings #616

merged 2 commits into from
Oct 16, 2024

Conversation

dylanratcliffe
Copy link
Member

Fixes #615

DavidS-ovm
DavidS-ovm approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@DavidS-ovm DavidS-ovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll work for now. Eventually we'll probably want to change that into a metric, or at least aggregate unmapped resources with the same type into a single event to save on honeycomb costs.

tfutils/plan_mapper.go Outdated Show resolved Hide resolved
@dylanratcliffe @DavidS-ovm
Improve attribute names
f2e0f67 
Co-authored-by: David Schmitt <[email protected]>
@dylanratcliffe dylanratcliffe merged commit e6c6b0d into main Oct 16, 2024
8 of 10 checks passed
@dylanratcliffe dylanratcliffe deleted the capture-failed-mappings branch October 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS-ovm DavidS-ovm DavidS-ovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture failed mappings as span events
2 participants
@dylanratcliffe @DavidS-ovm