Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the way mapping results are shown #415

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

dylanratcliffe
Copy link
Member

Fixes: overmindtech/aws-source#518

This makes the resource mapping output much clearer, we now show why something wasn't mapped if it is supported, rather than showing it as unsupported:

✔︎ Extracting 2 changing resources: 1 supported 1 unsupported
  ✔︎ aws_instance (1)
  ✗ aws_iam_role (1)

To:

✔︎ Extracting 4 changing resources
  ✔︎ module.scenarios[0].aws_iam_role.test_role (mapped)
  ? module.scenarios[0].aws_iam_role.test_role (missing arn)
  ✗ module.scenarios[0].aws_iam_role.test_role (not supported)

cmd/tea_submitplan.go Outdated Show resolved Hide resolved
Co-authored-by: David Schmitt <[email protected]>
@dylanratcliffe dylanratcliffe enabled auto-merge June 20, 2024 14:06
@dylanratcliffe dylanratcliffe merged commit 9dbbe57 into main Jun 20, 2024
5 checks passed
@dylanratcliffe dylanratcliffe deleted the fic-mapping-output branch June 20, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_role unsupported mapping
2 participants