Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move request to two commands #332

Merged
merged 3 commits into from
May 31, 2024
Merged

Move request to two commands #332

merged 3 commits into from
May 31, 2024

Conversation

dylanratcliffe
Copy link
Member

Previously the functionality around loading bookmarks and snapshots didn't actually work. I've not separated it into different commands so that it's a bit easier to use

I needed to do this so that I could get a snapshot into a CSV reliably for testing pagerank

@dylanratcliffe dylanratcliffe requested a review from DavidS-ovm May 27, 2024 16:12
dylanratcliffe and others added 3 commits May 31, 2024 11:14
Previously the functionality around loading bookmarks and snapshots didn't actually work. I've not separated it into different commands so that it's a bit easier to use
@DavidS-ovm DavidS-ovm force-pushed the load-properly branch 2 times, most recently from 623b4aa to 905e2ca Compare May 31, 2024 09:16
Copy link
Contributor

@DavidS-ovm DavidS-ovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, made a bit of a mess of the branch when I rebased with my own changes. Will merge as is, as all the individual changes are fine.

@DavidS-ovm DavidS-ovm merged commit 8cbad66 into main May 31, 2024
5 checks passed
@DavidS-ovm DavidS-ovm deleted the load-properly branch May 31, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants