feat: add markdown glamour styles #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS-ovm
approved these changes
Apr 12, 2024
|
|
DavidS-ovm
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Using markdownToString fails with a segfault. adding the missing error handling reveals
open ./overmind-theme.json: no such file or directory
This should instead use embed, e.g. like
Lines 32 to 33 in 12b9c37
|
@getinnocuous maybe add a small test for the method so I don't have to run the code in my head? |
|
I've added the test to give you a leg up here, @getinnocuous . Before merging this also should be rebased and squashed to clean up the history. |
DavidS-ovm
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly standalone and can be merged into main once #237 has.