Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charms #186

Merged
merged 18 commits into from
Mar 4, 2024
Merged

Charms #186

merged 18 commits into from
Mar 4, 2024

Conversation

DavidS-ovm
Copy link
Contributor

@DavidS-ovm DavidS-ovm commented Feb 21, 2024

2024-02-21_14MS+0100_1098x282

Some notes compared to the original design:

  • I didn't find a way to list available profiles, so this is just using the configured one ($AWS_PROFILE) or letting the user input one
  • crisped up the wording of the options
  • adjust the wording based on whether there is or is not $AWS_PROFILE set
  • if no ticket-link or change is specified, this now uses the hash of the tfplan JSON to connect changes
  • implemented ACCESSIBLE env var to enable glamour's screenreader mode
  • the re-used submit-plan code still needs a UI/UX pass to improve its output using charms
  • the overmind terraform plan command does require double dashes (--) to separate overmind and terraform CLI arguments to avoid confusing the cobra parser

Other changes

  • a few refactorings of cmd/changes_submit_plan.go to allow re-use of existing code with more flexibility
  • refactor token handling to pass through the actual oauth2.Token data for easier use in the nats token client

@DavidS-ovm DavidS-ovm linked an issue Feb 21, 2024 that may be closed by this pull request
@DavidS-ovm DavidS-ovm force-pushed the charms branch 6 times, most recently from 9db5990 to 699ebdc Compare February 28, 2024 17:27
@DavidS-ovm DavidS-ovm marked this pull request as ready for review February 29, 2024 09:43
@DavidS-ovm DavidS-ovm merged commit fa05ea3 into main Mar 4, 2024
5 checks passed
@DavidS-ovm DavidS-ovm deleted the charms branch March 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add some glamour
1 participant