Merge pull request #193 from overmindtech/progress-reporting

Improve progress reporting
overmindtech · Feb 24, 2024 · 78a13d8 · 78a13d8
2 parents 5a70449 + c88a954
commit 78a13d8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/cmd/changes_get_change.go b/cmd/changes_get_change.go
@@ -122,8 +122,25 @@ fetch:
 		}
 
 		if riskRes.Msg.GetChangeRiskMetadata().GetRiskCalculationStatus().GetStatus() == sdp.RiskCalculationStatus_STATUS_INPROGRESS {
-			log.WithContext(ctx).WithField("status", riskRes.Msg.GetChangeRiskMetadata().GetRiskCalculationStatus().GetStatus().String()).Info("waiting for risk calculation")
-			time.Sleep(10 * time.Second)
+			// Extract the currently running milestone if you can
+			milestones := riskRes.Msg.GetChangeRiskMetadata().GetRiskCalculationStatus().GetProgressMilestones()
+			var currentMilestone string
+			for _, milestone := range milestones {
+				if milestone == nil {
+					continue
+				}
+
+				if milestone.GetStatus() == sdp.RiskCalculationStatus_ProgressMilestone_STATUS_INPROGRESS {
+					currentMilestone = milestone.GetDescription()
+				}
+			}
+
+			log.WithContext(ctx).WithFields(log.Fields{
+				"status":    riskRes.Msg.GetChangeRiskMetadata().GetRiskCalculationStatus().GetStatus().String(),
+				"milestone": currentMilestone,
+			}).Info("Waiting for risk calculation")
+
+			time.Sleep(3 * time.Second)
 			// retry
 		} else {
 			// it's done (or errored)

diff --git a/cmd/datamaps/awssource.go b/cmd/datamaps/awssource.go