Add directconnect virtual interface and gateway attachment sources #373

tomasdembelli · 2024-01-22T22:52:07Z

Related to: #326

tomasdembelli

I have some questions for the gateway attachment source.
I appreciate the help in advance 🙏

sources/directconnect/direct-connect-gateway-attachment.go

dylanratcliffe · 2024-01-24T12:12:12Z

sources/directconnect/virturl-interface.go

+		},
+		OutputMapper: virtualInterfaceOutputMapper,
+		InputMapperSearch: func(ctx context.Context, client *directconnect.Client, scope, query string) (*directconnect.DescribeVirtualInterfacesInput, error) {
+			if strings.HasPrefix(query, connectionIDPrefix) {


So this Search implementaion allows you to search by conneciton ID rather than Virtual interface ID, nice. In this case you don't have to do a prefix, the docs comment of Search virtual interfaces by connection ID is enough here I think.

Thanks for this.

I went by this comment here.

I can change it as recommended as well.

Ah I see, let's check: @DavidS-ovm was there a particular reason you suggested a prefix on the search?

I was under the impression that there might be more search options than just the connection id, which then needed to be disambiguated.

Makes sense @tomasdembelli if there isn't another potential search option, then let's skip the prefix

Removed redundant prefixes.
bd8221b

dylanratcliffe · 2024-01-24T12:13:20Z

Looking good so far

DavidS-ovm · 2024-01-26T09:22:42Z

Pushed this branch to #376 to get a valid test run (as external contributions don't get an AWS token).

DavidS-ovm · 2024-01-26T09:31:27Z

=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query
    util.go:198: list is not supported for directconnect-direct-connect-gateway-attachment resources
        
        ErrorType: NOTFOUND
        Scope: 
        SourceName: 
        ItemType: 
        ResponderName: 
=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query
    util.go:266: expected error to be NOTFOUND, got OTHER
        Error: invalid query, expected in the format of "gateway_id:<some_id> virtual_interface_id:<some_id>"
--- FAIL: TestNewDirectConnectGatewayAttachmentSource (0.09s)
    --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query (0.00s)

dylanratcliffe

Overall very good work. A couple of links that could be added, and some small suggestion around blast propagation but overall it looks really good

dylanratcliffe · 2024-01-26T12:19:41Z

sources/directconnect/direct-connect-gateway-attachment.go

+					// https://docs.aws.amazon.com/directconnect/latest/APIReference/API_DirectConnectGatewayAttachment.html#API_DirectConnectGatewayAttachment_Contents
+					In: true,
+					// We can't affect the virtual interface
+					Out: false,


I think in this instance we would want the blast to propagate in both directions. If you imagine a graph which is direct-connect-gateway -> direct-connect-gateway-attachment -> directconnect-virtual-interface

If we were to change the gateway, the blast radius wouldn't include the interface, because the outbound blast prop is false. I think realistically if you were to change a direct connect connections it could affect the interfaces and the things that use them couldn't it?

Suggested change

Out: false,

Out: true,

Virtual interface <-> gateway relation is defined on the virtual interface source: https://github.com/tomasdembelli/aws-source/blob/main/sources/directconnect/virturl-interface.go#L61

So, changing a gateway would affect the associated virtual interfaces.

My understanding is that the attachment source is just a state source. There is no create or delete method for this source. So, it can only change if the associated sources (virtual interface and gateway) are changed.
It doesn't have a terraform source and a List method, so defining the gateway <-> interface relation on the sources itself seemed more robust to me.

But I see your point, in the graph, maybe it is better so see the gateway to interface connection over their attachment.
In that case we need to remove the relation between virtual interface and gateway on the interface (and soon on the gateway) source.

I can do the change (and as you mentioned in the other relevant comments), I just want to make sure we are on the same page.

Ah you're right, I hadn't noticed the direct relationship. In that case this implementation is good

dylanratcliffe · 2024-01-26T12:22:35Z

sources/directconnect/direct-connect-gateway-attachment.go

+					// This is not clearly documented, but it seems that if the gateway is deleted, the attachment state will change to detaching
+					In: true,
+					// We can't affect the direct connect gateway
+					Out: false,


I think you could probably argue this in both directions, but it's better to err on the side of true usually. If I ask ChatGPT it seems to think that changes in an interface could affect the gateway, and therefore we need the blast to propagate through the attachment

ChatGPT Response
In AWS, a Direct Connect Virtual Interface (VIF) and a Direct Connect Gateway (DX Gateway) are separate entities, but changes to a Direct Connect Virtual Interface can indirectly impact the traffic flow and connectivity associated with a Direct Connect Gateway. Let me explain how:

Routing Configuration: A Direct Connect Virtual Interface is associated with a BGP (Border Gateway Protocol) session that facilitates the exchange of routing information between your on-premises network and your AWS resources. When you make changes to the routing configuration of a Virtual Interface (e.g., adding or removing prefixes), it affects how traffic is routed between your on-premises network and the AWS resources associated with the Virtual Interface.

Direct Connect Gateway Association: If your Direct Connect Virtual Interface is associated with a Direct Connect Gateway (via attachment to a Virtual Private Gateway or Transit Gateway), changes in routing may impact the traffic flow to and from the resources in the associated VPCs or Transit Gateways. The Direct Connect Gateway relies on the routing information exchanged through the Virtual Interface.

BGP Session Changes: Any changes to the BGP session parameters, such as updating BGP communities or modifying the BGP session properties, can impact how routing decisions are made, which, in turn, can affect the Direct Connect Gateway's connectivity.

It's important to note that changes to a Direct Connect Virtual Interface are more likely to affect the specific routing and connectivity associated with that Virtual Interface rather than directly impacting the overall Direct Connect Gateway itself.

Always exercise caution when making changes to network configurations, and ensure that any modifications align with your overall networking requirements and design. It's recommended to carefully plan and test changes, especially in production environments, to minimize the risk of disruptions.

Suggested change

Out: false,

Out: true,

sources/directconnect/direct-connect-gateway-attachment_test.go

dylanratcliffe · 2024-01-26T12:28:20Z

sources/directconnect/virturl-interface.go

+			// +overmind:link ip
+			item.LinkedItemQueries = append(item.LinkedItemQueries, &sdp.LinkedItemQuery{
+				Query: &sdp.Query{
+					Type:   "ip",


The IP source doesn't support a GET using a CIDR, since it returns details of a single IP address. However the rdap-ip-network does, and gets details of that network block. Can we change this to do a SEARCH against that type instead?

dylanratcliffe · 2024-01-26T12:28:28Z

sources/directconnect/virturl-interface.go

+			// +overmind:link ip
+			item.LinkedItemQueries = append(item.LinkedItemQueries, &sdp.LinkedItemQuery{
+				Query: &sdp.Query{
+					Type:   "ip",


dylanratcliffe · 2024-01-26T12:29:12Z

sources/directconnect/virturl-interface.go

+					Type:   "directconnect-direct-connect-gateway-attachment",
+					Method: sdp.QueryMethod_GET,
+					// returns a single attachment
+					// TODO: implement this format on the directconnect-direct-connect-gateway-attachment source for GET


We can remove this TODO right?

Suggested change

// TODO: implement this format on the directconnect-direct-connect-gateway-attachment source for GET

dylanratcliffe · 2024-01-26T12:30:55Z

sources/directconnect/virturl-interface.go

+				},
+				BlastPropagation: &sdp.BlastPropagation{
+					// Changes to the attachment won't affect virtual interface
+					In: false,


Once again, because the attachment is a kind of "bridging" resource (like an IP often is) I'd argue it's worth having this as true so that changes to the direct connect gateway propagate through the attachment to the interface

Suggested change

In: false,

In: true,

dylanratcliffe · 2024-01-26T12:41:12Z

sources/directconnect/virturl-interface.go

+				},
+				BlastPropagation: &sdp.BlastPropagation{
+					// Changes to the attachment won't affect virtual interface
+					In: false,


As above

Suggested change

In: false,

In: true,

dylanratcliffe · 2024-01-26T12:50:15Z

sources/directconnect/virtual-interface_test.go

+				VirtualInterfaceType:   sources.PtrString("private"),
+				VirtualInterfaceName:   sources.PtrString("PrivateVirtualInterface"),
+				DirectConnectGatewayId: sources.PtrString("cf68415c-f4ae-48f2-87a7-3b52cexample"),
+			},


This has a field called VirtualGatewayId which will refer to https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directconnect#Client.DescribeVirtualGateways, a type that we will soon create. It's easier to create these links now than to go back and do them later. Since we have the naming convention and we know the CLI command for it: describe-virtual-gateways we can know that the type will be called directconnect-virtual-gateway so we can create a link in advance.

Personally I usually try to create test data for every field in the possible return value so it's easy to track which ones I've considered for possible links and which I haven't

I think virtaul interface and the virtual gateway are not directly connected. They are indirectly connected over direct connect gateway. That's why I didn't include it in the links on the virtual interface.

Each VPC has a virtual private gateway that connects to the Direct Connect gateway using a virtual private gateway association. The Direct Connect gateway uses a private virtual interface for the connection to the AWS Direct Connect location. There is an AWS Direct Connect connection from the location to the customer data center.

https://docs.aws.amazon.com/directconnect/latest/UserGuide/direct-connect-gateways-intro.html

What do you think?

Yep that reasoning makes sense. In future I think it'd be worth adding VirtualGatewayId into the test data, and a comment explaining that reasoning so I know that you've considered it and chosen not to include it rather than potentially missed it

tomasdembelli · 2024-01-27T22:59:36Z

Overall very good work. A couple of links that could be added, and some small suggestion around blast propagation but overall it looks really good

@dylanratcliffe thanks for the detailed comments.
I've addressed most of them.

I intentionally didn't update the ones related to the blast propagation between interface and gateway over the attachment source.
I am happy to do the changes as suggested, I just wanted to get your final confirmation.

tomasdembelli · 2024-01-27T23:01:23Z

=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query
    util.go:198: list is not supported for directconnect-direct-connect-gateway-attachment resources
        
        ErrorType: NOTFOUND
        Scope: 
        SourceName: 
        ItemType: 
        ResponderName: 
=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query
    util.go:266: expected error to be NOTFOUND, got OTHER
        Error: invalid query, expected in the format of "gateway_id:<some_id> virtual_interface_id:<some_id>"
--- FAIL: TestNewDirectConnectGatewayAttachmentSource (0.09s)
    --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query (0.00s)

@DavidS-ovm
Thanks for this.
The Attachment source does not have a list method as confirmed by @dylanratcliffe.
What can we do about the failing test for that?

For the other error, I've simplified the unique attribute and improved the error message.
I appreciate if you can re-run the tests.

DavidS-ovm · 2024-01-29T08:48:56Z

=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query
    util.go:198: list is not supported for directconnect-direct-connect-gateway-attachment resources
        
        ErrorType: NOTFOUND
        Scope: 
        SourceName: 
        ItemType: 
        ResponderName: 
=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query
    util.go:266: expected error to be NOTFOUND, got OTHER
        Error: invalid query, expected in the format of "gateway_id:<some_id> virtual_interface_id:<some_id>"
--- FAIL: TestNewDirectConnectGatewayAttachmentSource (0.09s)
    --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query (0.00s)

@DavidS-ovm Thanks for this. The Attachment source does not have a list method as confirmed by @dylanratcliffe. What can we do about the failing test for that?

For the other error, I've simplified the unique attribute and improved the error message. I appreciate if you can re-run the tests.

Still very similar, I think the generic e2e test suite is not prepared for a source that has some actual syntax checking.

Options:

fixup e2e suite to take params that allow more varied behavior
change this source to return expected errors
Implement different tests for this source

I think a mix of the first two is the way to go: add flag to disable list testing, change the syntax error to be a NOTFOUND

What do you think, @dylanratcliffe ?

=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query
    util.go:198: list is not supported for directconnect-direct-connect-gateway-attachment resources
        
        ErrorType: NOTFOUND
        Scope: 
        SourceName: 
        ItemType: 
        ResponderName: 
=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query
    util.go:266: expected error to be NOTFOUND, got OTHER
        Error: invalid query, expected in the format of gateway_id/virtual_interface_id, got: this is a known bad get query
--- FAIL: TestNewDirectConnectGatewayAttachmentSource (0.08s)
    --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query (0.00s)

dylanratcliffe · 2024-01-29T17:36:57Z

Yeah I'm with @DavidS-ovm, add a flag to E2ETest to skip the list test, or maybe an option to expect an error, and then change the Get error to NOTFOUND to match convention

tomasdembelli · 2024-01-29T22:33:58Z

=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query
    util.go:198: list is not supported for directconnect-direct-connect-gateway-attachment resources
        
        ErrorType: NOTFOUND
        Scope: 
        SourceName: 
        ItemType: 
        ResponderName: 
=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query
    util.go:266: expected error to be NOTFOUND, got OTHER
        Error: invalid query, expected in the format of "gateway_id:<some_id> virtual_interface_id:<some_id>"
--- FAIL: TestNewDirectConnectGatewayAttachmentSource (0.09s)
    --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query (0.00s)

@DavidS-ovm Thanks for this. The Attachment source does not have a list method as confirmed by @dylanratcliffe. What can we do about the failing test for that?
For the other error, I've simplified the unique attribute and improved the error message. I appreciate if you can re-run the tests.

Still very similar, I think the generic e2e test suite is not prepared for a source that has some actual syntax checking.

Options:

fixup e2e suite to take params that allow more varied behavior
change this source to return expected errors
Implement different tests for this source

I think a mix of the first two is the way to go: add flag to disable list testing, change the syntax error to be a NOTFOUND

What do you think, @dylanratcliffe ?

=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query
    util.go:198: list is not supported for directconnect-direct-connect-gateway-attachment resources
        
        ErrorType: NOTFOUND
        Scope: 
        SourceName: 
        ItemType: 
        ResponderName: 
=== RUN   TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query
    util.go:266: expected error to be NOTFOUND, got OTHER
        Error: invalid query, expected in the format of gateway_id/virtual_interface_id, got: this is a known bad get query
--- FAIL: TestNewDirectConnectGatewayAttachmentSource (0.08s)
    --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/List_query (0.00s)
        --- FAIL: TestNewDirectConnectGatewayAttachmentSource/Source:_directconnect-direct-connect-gateway-attachment-source/bad_get_query (0.00s)

Thanks @DavidS-ovm,

I've done the recommended changes.

DavidS-ovm · 2024-01-30T08:48:36Z

re-ran the tests, they're passing now.

dylanratcliffe · 2024-01-30T08:51:40Z

sources/directconnect/direct-connect-gateway-attachment.go

+					// https://docs.aws.amazon.com/directconnect/latest/APIReference/API_DirectConnectGatewayAttachment.html#API_DirectConnectGatewayAttachment_Contents
+					In: true,
+					// We can't affect the virtual interface
+					Out: false,


Ah you're right, I hadn't noticed the direct relationship. In that case this implementation is good

dylanratcliffe · 2024-01-30T08:54:35Z

sources/directconnect/virtual-interface_test.go

+				VirtualInterfaceType:   sources.PtrString("private"),
+				VirtualInterfaceName:   sources.PtrString("PrivateVirtualInterface"),
+				DirectConnectGatewayId: sources.PtrString("cf68415c-f4ae-48f2-87a7-3b52cexample"),
+			},


Yep that reasoning makes sense. In future I think it'd be worth adding VirtualGatewayId into the test data, and a comment explaining that reasoning so I know that you've considered it and chosen not to include it rather than potentially missed it

dylanratcliffe

LGTM, only thing it needs is for these sources to get added to cmd.go so they actually get loaded: https://github.com/overmindtech/aws-source/blob/main/cmd/root.go#L236

tomasdembelli · 2024-01-30T21:50:19Z

LGTM, only thing it needs is for these sources to get added to cmd.go so they actually get loaded: https://github.com/overmindtech/aws-source/blob/main/cmd/root.go#L236

I've addressed this.
743cb68

tomasdembelli changed the title ~~Add directconnect virtual interface source~~ Add directconnect virtual interface and gateway attachment sources Jan 23, 2024

tomasdembelli commented Jan 23, 2024

View reviewed changes

sources/directconnect/direct-connect-gateway-attachment.go Outdated Show resolved Hide resolved

sources/directconnect/direct-connect-gateway-attachment.go Show resolved Hide resolved

sources/directconnect/direct-connect-gateway-attachment.go Show resolved Hide resolved

dylanratcliffe self-requested a review January 24, 2024 11:48

dylanratcliffe reviewed Jan 24, 2024

View reviewed changes

tomasdembelli requested a review from dylanratcliffe January 25, 2024 17:39

DavidS-ovm mentioned this pull request Jan 26, 2024

Test 373 #376

Merged

dylanratcliffe requested changes Jan 26, 2024

View reviewed changes

tomasdembelli added 7 commits January 27, 2024 20:57

chore(directconnect-connection): use constant for query format

a6216b5

feat(directconnect): add virtual interface source

f8d463c

feat(directconnect): add direct connect gateway attachment source

8d5932b

chore(directconnect): update virtual interface source

324fe42

chore: update dependencies

2046b02

chore: add unique name to gateway attachment

df20832

Remove redundant prefixes from search queries

be05284

tomasdembelli force-pushed the main branch from bd8221b to be05284 Compare January 27, 2024 20:57

tomasdembelli added 4 commits January 27, 2024 21:06

improve error message

a6d440a

add health check on gateway attachment

adfa944

Use rdap-ip-network soruce for cidr addresses

c8a3021

Simplify attachment unique attribute

8ea8e71

generate docs

23da274

Add skip list test flag to e2e test suit

89b78e1

tomasdembelli requested a review from dylanratcliffe January 29, 2024 22:36

Use known error type

8370de4

tomasdembelli force-pushed the main branch from 45439e5 to 8370de4 Compare January 29, 2024 22:41

dylanratcliffe approved these changes Jan 30, 2024

View reviewed changes

dylanratcliffe requested changes Jan 30, 2024

View reviewed changes

Add direct connect resources to root

743cb68

tomasdembelli requested a review from dylanratcliffe January 30, 2024 21:50

dylanratcliffe approved these changes Jan 30, 2024

View reviewed changes

dylanratcliffe enabled auto-merge January 30, 2024 22:35

dylanratcliffe disabled auto-merge January 31, 2024 11:41

dylanratcliffe merged commit adb0c38 into overmindtech:main Jan 31, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add directconnect virtual interface and gateway attachment sources #373

Add directconnect virtual interface and gateway attachment sources #373

tomasdembelli commented Jan 22, 2024

tomasdembelli left a comment

dylanratcliffe Jan 24, 2024

tomasdembelli Jan 24, 2024

dylanratcliffe Jan 24, 2024

DavidS-ovm Jan 25, 2024

dylanratcliffe Jan 25, 2024

tomasdembelli Jan 25, 2024

dylanratcliffe commented Jan 24, 2024

DavidS-ovm commented Jan 26, 2024 •

edited

Loading

DavidS-ovm commented Jan 26, 2024

dylanratcliffe left a comment

dylanratcliffe Jan 26, 2024

tomasdembelli Jan 27, 2024

dylanratcliffe Jan 30, 2024

dylanratcliffe Jan 26, 2024

dylanratcliffe Jan 26, 2024

tomasdembelli Jan 27, 2024

dylanratcliffe Jan 26, 2024

dylanratcliffe Jan 26, 2024

dylanratcliffe Jan 26, 2024

dylanratcliffe Jan 26, 2024

dylanratcliffe Jan 26, 2024

tomasdembelli Jan 27, 2024

dylanratcliffe Jan 30, 2024

tomasdembelli commented Jan 27, 2024

tomasdembelli commented Jan 27, 2024

DavidS-ovm commented Jan 29, 2024

dylanratcliffe commented Jan 29, 2024

tomasdembelli commented Jan 29, 2024

DavidS-ovm commented Jan 30, 2024

dylanratcliffe Jan 30, 2024

dylanratcliffe Jan 30, 2024

dylanratcliffe left a comment

tomasdembelli commented Jan 30, 2024

Add directconnect virtual interface and gateway attachment sources #373

Add directconnect virtual interface and gateway attachment sources #373

Conversation

tomasdembelli commented Jan 22, 2024

tomasdembelli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dylanratcliffe commented Jan 24, 2024

DavidS-ovm commented Jan 26, 2024 • edited Loading

DavidS-ovm commented Jan 26, 2024

dylanratcliffe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomasdembelli commented Jan 27, 2024

tomasdembelli commented Jan 27, 2024

DavidS-ovm commented Jan 29, 2024

dylanratcliffe commented Jan 29, 2024

tomasdembelli commented Jan 29, 2024

DavidS-ovm commented Jan 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dylanratcliffe left a comment

Choose a reason for hiding this comment

tomasdembelli commented Jan 30, 2024

DavidS-ovm commented Jan 26, 2024 •

edited

Loading